Skip to content

fix(ui5-side-navigation): expand SideNavigation item activation to Enter or Space with modifier keys #12091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(ui5-side-navigation): expand SideNavigation item activation to Enter or Space with modifier keys #12091

wants to merge 6 commits into from
+29 −24

Conversation

LidiyaGeorgieva
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva commented Aug 8, 2025 •
edited
Loading

Side navigation items can now be activated using Enter or Space, with or without modifier keys (Shift, Ctrl, Alt, Meta).

JIRA: BGSOFUIRODOPI-3466

@LidiyaGeorgieva
fix(ui5-side-navigation): trigger "click" on the NavigationListItem w…
c783129 
…hen a modifier is pressed

This is for the usage of "Space" and "Enter" keys

JIRA: BGSOFUIRODOPI-3466
@LidiyaGeorgieva LidiyaGeorgieva requested review from a team and Stoev August 8, 2025 12:34
Stoev
Stoev reviewed Aug 11, 2025
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative commit header text:
fix(ui5-side-navigation): expand SideNavigation item activation to Enter or Space with modifier keys

  • Side navigation items can now be activated using Enter or Space, with or without modifier keys (Shift, Ctrl, Alt, Meta).

@LidiyaGeorgieva LidiyaGeorgieva changed the title fix(ui5-side-navigation): trigger "click" on the NavigationListItem when a modifier is pressed fix(ui5-side-navigation): expand SideNavigation item activation to Enter or Space with modifier keys Aug 12, 2025
@LidiyaGeorgieva LidiyaGeorgieva changed the title fix(ui5-side-navigation): expand SideNavigation item activation to Enter or Space with modifier keys fix(ui5-side-navigation): expand SideNavigation item activation to Enter or Space with modifier keys Aug 12, 2025
@LidiyaGeorgieva LidiyaGeorgieva requested a review from Stoev August 12, 2025 06:38
Stoev
Stoev reviewed Aug 12, 2025
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, looks good.

s-todorova
s-todorova requested changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@s-todorova s-todorova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. No Modifier+Enter/Space combinations work for items in the overflow menu
  2. In expanded mode, on test page:
    -> Select the first item 'Home'
    -> Arrow down until the item 'Home 3' is focusd (the one before 'Quick Create parent' item)
    -> Press Shift + Space
    --->> Item is selected but unexpected scrolling occurs.
    This does not happen for Shift+Enter (perhaps a preventDefault is needed) and the same does not happen in openui5 (see sample - try to shift+space select the 'Map' item that is down the list)

@LidiyaGeorgieva
Copy link
Contributor Author

  1. No Modifier+Enter/Space combinations work for items in the overflow menu
  2. In expanded mode, on test page:
    -> Select the first item 'Home'
    -> Arrow down until the item 'Home 3' is focusd (the one before 'Quick Create parent' item)
    -> Press Shift + Space
    --->> Item is selected but unexpected scrolling occurs.
    This does not happen for Shift+Enter (perhaps a preventDefault is needed) and the same does not happen in openui5 (see sample - try to shift+space select the 'Map' item that is down the list)
  1. fixed
  2. it is browser specific key combination
image

@duygu-rmdn
Copy link
Contributor

On macOS:

All combinations with Enter work as expected.
Meta + Space and Ctrl + Space trigger macOS system shortcuts.
Alt + Space and Shift + Space do not activate the item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-todorova s-todorova Awaiting requested review from s-todorova

@duygu-rmdn duygu-rmdn Awaiting requested review from duygu-rmdn

@alexandar-mitsev alexandar-mitsev Awaiting requested review from alexandar-mitsev

@TeodorTaushanov TeodorTaushanov Awaiting requested review from TeodorTaushanov

1 more reviewer

@Stoev Stoev Stoev left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LidiyaGeorgieva @duygu-rmdn @Stoev @s-todorova